]> dgit.raspbian.org Git - gnome-shell.git/commit
projects / gnome-shell.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 32ddb6f) | patch
appDisplay: Don't leak duplicate items in AppView
authorRay Strode <rstrode@redhat.com>
Mon, 15 Jul 2019 17:52:58 +0000 (13:52 -0400)
committerRay Strode <halfline@gmail.com>
Tue, 23 Jul 2019 14:53:24 +0000 (14:53 +0000)
commiteaa32090b9c214106ee1b094c2a1b801516b055f
treebe3e3d1c5567b84c5db9162b63701cc60f747fc9tree | snapshot
parent32ddb6f739a03ff2647ea606103aecf14cbc89dacommit | diff
appDisplay: Don't leak duplicate items in AppView

If an icon already exists in an app view with the same id, the
duplicate is not added on a call to addItem.  Unfortunately,
since it's not added, the icon actor gets orphaned and leaked.

This commit address the problem by introducing a new hasItem
method and disallowing callers to call addItem with a duplicate
in the first place.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/628
js/ui/appDisplay.js diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.